src/classes/stageClasses/missions/ZoneMission.lua

@@ -66,8 +66,6 @@ local function ParseZoneName(input)
     }
 end
 
-MINIMAL_UNITS_ALIVE_RATIO = 0.21
-
 ---comment
 ---@param zoneName string
 ---@param priority MissionPriority
@@ -232,7 +230,7 @@ end
 ---@param messageIfDone boolean
 function ZoneMission:UpdateState(checkHealth, messageIfDone)
     if checkHealth == nil then checkHealth = false end
-    if messageIfDone == false then messageIfDone = true end
+    if messageIfDone == nil then messageIfDone = true end
 
 
     if checkHealth == true then

src/classes/stageClasses/missions/baseMissions/Mission.lua

@@ -133,9 +133,9 @@ function Mission:ForceMissionComplete()
     self:NotifyMissionComplete()
 end
 
----@param groupId number
+---@param _groupId number
 ---@diagnostic disable-next-line: unused-local
-function Mission:MarkMissionAreaToGroup(groupId) end
+function Mission:MarkMissionAreaToGroup(_groupId) end
 
 ---endregion
 
@@ -147,29 +147,26 @@ function Mission:ToStateString() return "status: in progress" end
 
 --endregion
 
-do --aliases
+--- @alias MissionPriority
+--- | "none"
+--- | "primary"
+--- | "secondary"
 
-    --- @alias MissionPriority
-    --- | "none"
-    --- | "primary"
-    --- | "secondary"
+--- @alias MissionType
+--- | "nil"
+--- | "STRIKE"
+--- | "CAS"
+--- | "BAI"
+--- | "DEAD"
+--- | "SAM"
+--- | "OCA"
+--- | "LOGISTICS"
 
-    --- @alias MissionType
-    --- | "nil"
-    --- | "STRIKE"
-    --- | "CAS"
-    --- | "BAI"
-    --- | "DEAD"
-    --- | "SAM"
-    --- | "OCA"
-    --- | "LOGISTICS"
+--- @alias MissionState
+--- | "NEW"
+--- | "WAITING"
+--- | "ACTIVE"
+--- | "COMPLETED"
 
-    --- @alias MissionState
-    --- | "NEW"
-    --- | "WAITING"
-    --- | "ACTIVE"
-    --- | "COMPLETED"
-
-end
 
 return Mission