Spearhead/spearhead
3
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Releases 2 Wiki Activity

Feature/lanes #40

Merged
dutchie031 merged 12 commits from feature/lanes into develop 2026-09-07 17:08:27 +00:00
Conversation 3 Commits 12 Files Changed 35
+4500 -458
dutchie031 commented 2026-08-25 16:40:39 +00:00
Owner
Copy Link
Copy Source

this fixes #35

does not close but starts work partly on #41

this fixes #35 does not close but starts work partly on #41
dutchie031 changed target branch from main to develop 2026-08-25 16:40:46 +00:00
dutchie031 added 2 commits 2026-08-25 16:40:46 +00:00
added drawing for lane logic b9068a7ac8
Created lane feature that should be backwards compatible with non-lane features 27548d69bb
dutchie031 marked the pull request as work in progress 2026-08-26 10:56:34 +00:00
dutchie031 added 1 commit 2026-08-30 12:12:53 +00:00
wip 51bed10822
dutchie031 added 1 commit 2026-08-30 12:13:08 +00:00
wip c10c743fe8
dutchie031 reviewed 2026-08-31 18:57:32 +00:00
dutchie031 left a comment
Author
Owner
Copy Link
Copy Source

Initial comments added for myself

Initial comments added for myself
src/classes/persistence/Persistence.lua Outdated
@@ -34,3 +34,3 @@
random_missions = {},
deliveredKilos = {},
activeStage = nil
activeStageInStageLane = {}
dutchie031 commented 2026-08-31 18:37:42 +00:00
Author
Owner
Copy Link
Copy Source

This breaks backwards compatibility when inserted into missions that already have a persistent file.

This breaks backwards compatibility when inserted into missions that already have a persistent file.
dutchie031 marked this conversation as resolved
src/classes/spearhead_events.lua Outdated
@@ -37,41 +37,36 @@ do
---Add a stage zone number changed listener
---@param listener OnStageChangedListener object with function OnStageNumberChanged(self, number)
dutchie031 commented 2026-08-31 18:40:32 +00:00
Author
Owner
Copy Link
Copy Source

comment needs updating

comment needs updating
dutchie031 marked this conversation as resolved
src/classes/stageClasses/GlobalStageManager.lua
@@ -216,4 +316,2 @@
currentStage = stageNumber
self:UpdateDrawings(stageNumber)
end
dutchie031 commented 2026-08-31 18:50:53 +00:00
Author
Owner
Copy Link
Copy Source

drawings should also follow lanes

drawings should also follow lanes
dutchie031 marked this conversation as resolved
dutchie031 added 1 commit 2026-09-01 07:04:07 +00:00
Resolved first comments and made StageDrawings explicit classes that now also follow lane identifiers 4de9e91efd
dutchie031 added 1 commit 2026-09-01 10:34:37 +00:00
wrote documentation for lanes 368310d026
dutchie031 reviewed 2026-09-01 10:50:10 +00:00
src/classes/stageClasses/Stages/ExtraStage.lua
@@ -40,0 +39,4 @@
---@param stageLaneIdentifier string?
function ExtraStage:OnStageNumberChanged(number, stageLaneIdentifier)
if stageLaneIdentifier ~= self._stageLaneIdentifier then
dutchie031 commented 2026-09-01 10:50:10 +00:00
Author
Owner
Copy Link
Copy Source

Pre-Activation also should take into account that Inter lane dependencies exist

Pre-Activation also should take into account that Inter lane dependencies exist
dutchie031 marked this conversation as resolved
dutchie031 reviewed 2026-09-01 11:40:34 +00:00
.docs/web/pages/advanced/lanes.html Outdated
@@ -0,0 +100,4 @@
</p>
<h3 id="mermaid-log-example">Log Example</h3>
<p> TODO: Show log example</p>
dutchie031 commented 2026-09-01 11:40:34 +00:00
Author
Owner
Copy Link
Copy Source

TODOs

TODOs
dutchie031 marked this conversation as resolved
dutchie031 added 2 commits 2026-09-01 11:54:39 +00:00
updated docs and release notes 4b1ec92235
minor change addressing PR 1b46b828a6
dutchie031 added 1 commit 2026-09-01 16:07:08 +00:00
updated stage logic e8e12cf892
dutchie031 added 1 commit 2026-09-01 18:13:27 +00:00
added examples 2a7febfa4d
dutchie031 added 2 commits 2026-09-07 17:00:44 +00:00
updated docs, Util functions and fixed last issues 145eb385bc
updated docs, Util functions and fixed last issues 6ca92dd01b
dutchie031 marked the pull request as ready for review 2026-09-07 17:07:02 +00:00
dutchie031 merged commit 772397250f into develop 2026-09-07 17:08:27 +00:00
dutchie031 deleted branch feature/lanes 2026-09-07 17:08:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
dutchie031
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Complete
4
The issue was fixed and completed in a good manner
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
6
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Picked Up
3
Status
ReadyToBePickedUp
4
Status
ToBeRefined
5
To be refined, before implementation can be started
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
dutchie031 (Dutchie) Luke Wolf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Spearhead/spearhead#40